Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix openMP deps on macos when using DGtalConfig.cmake #1578

Merged
merged 4 commits into from
Jun 15, 2021
Merged

Fix openMP deps on macos when using DGtalConfig.cmake #1578

merged 4 commits into from
Jun 15, 2021

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented Jun 3, 2021 •
edited
Loading

PR Description

OpenMP on macOS

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

kerautret
kerautret approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@kerautret kerautret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine tested with and without openmp installed 👍🏻

@kerautret
Copy link
Member

thanks merging !

@kerautret kerautret merged commit 55b36ee into DGtal-team:master Jun 15, 2021
@dcoeurjo dcoeurjo deleted the openmpdgtal branch October 7, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerautret kerautret kerautret approved these changes

Assignees
No one assigned
Labels
Build ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcoeurjo @kerautret