bug fix in initialization of plane-probing computers on to digital surfaces #1607
+155
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ght isValid functions and initialization frames
dcoeurjo
approved these changes
Oct 1, 2021
Co-authored-by: David Coeurjolly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
There was a bug in ExamplePlaneProbingSurfaceLocalEstimator (when built in Debug mode). It was caused by a bad validity check and a corner case in the initialization step, because a computer may not be always initialized (See method 'eval' in PlaneProbingDigitalSurfaceLocalEstimator). ExamplePlaneProbingSurfaceLocalEstimator can now be run without error.
Checklist
(Not relevant for a bug fix)
Unit-test of your feature with Catch.
Doxygen documentation of the code completed (classes, methods, types, members...)
Documentation module page added or updated.
New entry in the ChangeLog.md added.
No warning raised in Debug
cmakemode (otherwise, C.I. will fail).All continuous integration tests pass (Github Actions & appveyor)