Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing imagemagick and using stb_image instead #1648

Merged
merged 27 commits into from
Jul 3, 2022
Merged

Removing imagemagick and using stb_image instead #1648

merged 27 commits into from
Jul 3, 2022

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented Jun 24, 2022 •
edited
Loading

PR Description

This PR removes the optional ImageMagick dependency and adds image reader/writer using the stb_image files (included in DGtal).

The image import/export features in jpg, png, bmp and tga are now built-in in DGtal.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions & appveyor)

@dcoeurjo dcoeurjo marked this pull request as ready for review June 24, 2022 06:59
@dcoeurjo
Copy link
Member Author

ready for review;)

kerautret
kerautret requested changes Jun 26, 2022
View reviewed changes
Copy link
Member

@kerautret kerautret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! Thanks, just some small suggest and a PR on your branch from another Magick ref to remove

.github/workflows/checkDoxygenDocumentation.sh Show resolved Hide resolved
ChangeLog.md Outdated Show resolved Hide resolved
examples/arithmetic/lower-integer-convex-hull.cpp Outdated Show resolved Hide resolved
src/DGtal/io/doc/moduleIO.dox Outdated Show resolved Hide resolved
src/DGtal/io/doc/moduleIO.dox Outdated Show resolved Hide resolved
src/DGtal/io/readers/GenericReader.ih Show resolved Hide resolved
src/DGtal/io/readers/STBReader.h Outdated Show resolved Hide resolved
src/DGtal/io/readers/STBReader.ih Outdated Show resolved Hide resolved
src/DGtal/io/writers/STBWriter.h Outdated Show resolved Hide resolved
src/DGtal/io/writers/STBWriter.ih Outdated Show resolved Hide resolved
dcoeurjo and others added 7 commits June 27, 2022 08:38
@kerautret
Copy link
Member

@dcoeurjo looks fine, and for the gif format ?

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Jul 2, 2022

The method is still missing. I'll do it asap. Thx for the review

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Jul 2, 2022

Ok gif added in the reader. Thx @kerautret

@dcoeurjo dcoeurjo requested a review from kerautret July 2, 2022 13:10
@dcoeurjo dcoeurjo merged commit e932904 into DGtal-team:master Jul 3, 2022
@dcoeurjo dcoeurjo deleted the stb branch July 3, 2022 14:22
@dcoeurjo
Copy link
Member Author

dcoeurjo commented Jul 3, 2022

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerautret kerautret kerautret approved these changes

Assignees

@kerautret kerautret

Labels
IO-Visualisation ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcoeurjo @kerautret