Add material surface mesh reader #1677
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea why the testMeshVoxelization test aborts. It is not related to this PR. |
…SurfaceMeshReader
|
#1674 fixes the python test issues |
dcoeurjo
reviewed
Feb 9, 2023
| /// Reads an input file as an OBJ file format and outputs the | ||
| /// corresponding surface mesh. | ||
| /// | ||
| /// @param[in,out] input the input stream where the OBJ file is read. |
There was a problem hiding this comment.
Suggested change
| /// @param[in,out] input the input stream where the OBJ file is read. | |
| /// @param[in,out] input the input stream from which the OBJ file is read. |
?
| @@ -89,6 +99,11 @@ readOBJ( std::istream & input, SurfaceMesh & smesh ) | |||
| } else if ( keyword == "vn" ) { | |||
| lineinput >> n[ 0 ] >> n[ 1 ] >> n[ 2 ]; | |||
| normals.push_back( n ); | |||
| } else if ( keyword == "usemtl" ) { | |||
There was a problem hiding this comment.
Could you please reformat with the ˋ{`on single lines?
| /// | ||
| /// @param[in,out] input the input stream where the OBJ file is read. | ||
| /// @param[out] smesh the output surface mesh. | ||
| /// @param[out] materials a vector containing the material of each face (an index). |
There was a problem hiding this comment.
Suggested change
| /// @param[out] materials a vector containing the material of each face (an index). | |
| /// @param[out] materials a vector containing the material of each face (an index, may be empty) |
If there is no material info, an empty vector is retuned, right ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add reading material information in OBJ files for SurfaceMeshReader.
Checklist