Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option to put material part inside obj file #1686

Merged
merged 5 commits into from
Feb 16, 2023
Merged

option to put material part inside obj file #1686

merged 5 commits into from
Feb 16, 2023
+40 −13

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented Feb 16, 2023 •
edited
Loading

PR Description

Even if it is not the default behavior this option can usefully to simplify the display and archive of online demonstrations.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions & appveyor)

dcoeurjo
dcoeurjo previously approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dcoeurjo dcoeurjo self-requested a review February 16, 2023 20:08
dcoeurjo
dcoeurjo reviewed Feb 16, 2023
View reviewed changes
ChangeLog.md Outdated Show resolved Hide resolved
@dcoeurjo dcoeurjo merged commit a374748 into DGtal-team:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoeurjo dcoeurjo dcoeurjo left review comments

Assignees
No one assigned
Labels
IO-Visualisation ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerautret @dcoeurjo