Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface helper tuto fill contours #827

Merged
merged 23 commits into from
Aug 21, 2014
Merged

Surface helper tuto fill contours #827

merged 23 commits into from
Aug 21, 2014

Conversation

kerautret
Copy link
Member

Add doc on filling contour region in complement of Surface class from topology/helper.
A new example in link to the freeman2pgm tool of DGTalTools and new function uComputeExterior.
The test was also updated and the contour tests/samples/contourS.fc was updated (since he was obtained with an inverted cell selection).

@kerautret
Copy link
Member Author

@troussil, in the last commit I also update the contourS.fc in the direct orientation, and you use it in :
geometry/curves/exampleGridCurve2d.cpp, I suppose that it is not a problem but let me know you have to change something in the example or in doc reference it.

dcoeurjo
dcoeurjo reviewed Jun 26, 2014
View reviewed changes
src/DGtal/topology/helpers/Surfaces.h
* Given a boundary surface [bdry] in [ks], compute its exterior as a
* set of unoriented spels. The technique is to fill line by line and
* tests the intersection with the surface.
*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCellSet -> insist in the fact that it should reflect a closed surface.

@dcoeurjo dcoeurjo added this to the 0.8 milestone Jun 26, 2014
@kerautret
Copy link
Member Author

@dcoeurjo as discussed with @JacquesOlivierLachaud I change it with SurfelPredicate and with ImageContainer template (since it is used usually with image).
I have updated the test/example, I just look the consistency of tuto since it change a little.

@dcoeurjo
Copy link
Member

Can I check this PR ?

@kerautret
Copy link
Member Author

yes It could be nice ! :)

dcoeurjo
dcoeurjo reviewed Jul 22, 2014
View reviewed changes
src/DGtal/topology/doc/moduleDigitalSurfaceHelpers.dox



To construct the set of signed SCell, we exploit the method getInterPixelLinels of FreemanChain class:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCells, we use the

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

dcoeurjo
dcoeurjo reviewed Jul 22, 2014
View reviewed changes
src/DGtal/topology/doc/moduleDigitalSurfaceHelpers.dox

@snippet topology/ctopo-fillContours.cpp ctopoFillContoursFillRegion

The interior Cell obtained from such a contour are illustrated here:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cells

@kerautret
Copy link
Member Author

corrected thank!

@kerautret
Copy link
Member Author

@dcoeurjo can we merge ?

@dcoeurjo
Copy link
Member

This can be merged but Surfaces.h is a bit messy and should be refactored a little bit (there are only 2D things, some nD functions...).

dcoeurjo added a commit that referenced this pull request Aug 21, 2014
@dcoeurjo
Merge pull request #827 from kerautret/SurfaceHelperTutoFillContours
528f2b6 
Surface helper tuto fill contours
@dcoeurjo dcoeurjo merged commit 528f2b6 into DGtal-team:master Aug 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Topology
Projects
None yet
Milestone
0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@kerautret @dcoeurjo