Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thresholder fix #843

Merged
merged 12 commits into from
Jul 16, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@

## New Features

- *Base*
- *General*
- This Changelog has been ported to MarkDown (David Coeurjolly,
[#846](https://github.com/DGtal-team/DGtal/pull/846))
- The DGtal main website is now http://dgtal.org

- *Geometry Package*
- Add digital nD Voronoi Covariance Measure support, as well as
Expand Down Expand Up @@ -100,7 +101,8 @@
- *Image Package*
- Fixing template types in ImageAdapter (David Coeurjolly,
[#835](https://github.com/DGtal-team/DGtal/pull/835))
- Fixing image thresholders which require CConstImage instead of
- Fixing image thresholders (SimpleThresholdForegroundPredicate and
IntervalForegroundPredicate) which require CConstImage instead of
CImage (David Coeurjolly,
[#843](https://github.com/DGtal-team/DGtal/pull/843))

Expand Down
2 changes: 1 addition & 1 deletion examples/geometry/surfaces/dvcm-3d.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
#include "DGtal/topology/DigitalSurface.h"
#include "DGtal/topology/ImplicitDigitalSurface.h"
#include "DGtal/images/ImageSelector.h"
#include "DGtal/images/imagesSetsUtils/IntervalForegroundPredicate.h"
#include "DGtal/images/IntervalForegroundPredicate.h"
#include "DGtal/geometry/volumes/distance/ExactPredicateLpSeparableMetric.h"
#include "DGtal/geometry/surfaces/estimation/VoronoiCovarianceMeasureOnDigitalSurface.h"
#include "DGtal/io/colormaps/GradientColorMap.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
#include "DGtal/io/readers/VolReader.h"
#include "DGtal/images/ImageSelector.h"
#include "DGtal/images/imagesSetsUtils/SetFromImage.h"
#include "DGtal/images/imagesSetsUtils/SimpleThresholdForegroundPredicate.h"
#include "DGtal/images/SimpleThresholdForegroundPredicate.h"
#include "DGtal/topology/SurfelAdjacency.h"
#include "DGtal/topology/helpers/Surfaces.h"
#include "DGtal/topology/LightImplicitDigitalSurface.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
#include "DGtal/io/readers/VolReader.h"
#include "DGtal/images/ImageSelector.h"
#include "DGtal/images/imagesSetsUtils/SetFromImage.h"
#include "DGtal/images/imagesSetsUtils/SimpleThresholdForegroundPredicate.h"
#include "DGtal/images/SimpleThresholdForegroundPredicate.h"
#include "DGtal/topology/helpers/Surfaces.h"
#include "DGtal/topology/LightImplicitDigitalSurface.h"
#include "DGtal/images/ImageHelper.h"
Expand Down
2 changes: 1 addition & 1 deletion examples/geometry/volumes/distance/distancetransform2D.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
#include "DGtal/io/colormaps/HueShadeColorMap.h"
#include "DGtal/io/boards/Board2D.h"
#include "DGtal/images/ImageSelector.h"
#include "DGtal/images/imagesSetsUtils/SimpleThresholdForegroundPredicate.h"
#include "DGtal/images/SimpleThresholdForegroundPredicate.h"
#include "DGtal/geometry/volumes/distance/DistanceTransformation.h"
///////////////////////////////////////////////////////////////////////////////

Expand Down
2 changes: 1 addition & 1 deletion examples/geometry/volumes/distance/distancetransform3D.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
#include "DGtal/images/ImageSelector.h"

#include "DGtal/geometry/volumes/distance/DistanceTransformation.h"
#include "DGtal/images/imagesSetsUtils/SimpleThresholdForegroundPredicate.h"
#include "DGtal/images/SimpleThresholdForegroundPredicate.h"
#include "DGtal/helpers/StdDefs.h"

#include "ConfigExamples.h"
Expand Down
2 changes: 1 addition & 1 deletion examples/geometry/volumes/distance/voronoimap2D.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

//! [Voro2D-header]
#include "DGtal/kernel/BasicPointPredicates.h"
#include "DGtal/images/imagesSetsUtils/SimpleThresholdForegroundPredicate.h"
#include "DGtal/images/SimpleThresholdForegroundPredicate.h"
#include "DGtal/geometry/volumes/distance/ExactPredicateLpSeparableMetric.h"
#include "DGtal/geometry/volumes/distance/VoronoiMap.h"
#include "DGtal/geometry/volumes/distance/DistanceTransformation.h"
Expand Down
2 changes: 1 addition & 1 deletion examples/tutorial-examples/imageSetDT.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
#include "DGtal/images/ImageContainerBySTLVector.h"
#include "DGtal/images/ImageHelper.h"
#include "DGtal/geometry/volumes/distance/DistanceTransformation.h"
#include "DGtal/images/imagesSetsUtils/IntervalForegroundPredicate.h"
#include "DGtal/images/IntervalForegroundPredicate.h"

#include "DGtal/io/boards/Board2D.h"
#include "DGtal/io/readers/PGMReader.h"
Expand Down
2 changes: 1 addition & 1 deletion examples/tutorial-examples/polyhedralizer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
#include "DGtal/io/readers/VolReader.h"
#include "DGtal/images/ImageSelector.h"
#include "DGtal/images/ImageContainerBySTLVector.h"
#include "DGtal/images/imagesSetsUtils/SimpleThresholdForegroundPredicate.h"
#include "DGtal/images/SimpleThresholdForegroundPredicate.h"
//! [polyhedralizer-includes-readvol]

#include "DGtal/io/Display3D.h"
Expand Down
2 changes: 1 addition & 1 deletion examples/tutorial-examples/volDTGranulo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
#include "DGtal/io/readers/VolReader.h"
#include "DGtal/io/writers/VolWriter.h"

#include "DGtal/images/imagesSetsUtils/SimpleThresholdForegroundPredicate.h"
#include "DGtal/images/SimpleThresholdForegroundPredicate.h"
#include "DGtal/geometry/volumes/distance/DistanceTransformation.h"
#include "DGtal/shapes/implicit/ImplicitBall.h"
#include "DGtal/base/BasicFunctors.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
// Inclusions
#include <iostream>
#include "DGtal/base/Common.h"
#include "DGtal/images/CImage.h"
#include "DGtal/images/CConstImage.h"
#include "DGtal/base/ConstAlias.h"
//////////////////////////////////////////////////////////////////////////////

Expand All @@ -63,7 +63,7 @@ namespace DGtal
class IntervalForegroundPredicate
{
public:
BOOST_CONCEPT_ASSERT(( CImage<Image> ));
BOOST_CONCEPT_ASSERT(( CConstImage<Image> ));

typedef typename Image::Value Value;
typedef typename Image::Point Point;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
// Inclusions
#include <iostream>
#include "DGtal/base/Common.h"
#include "DGtal/images/CImage.h"
#include "DGtal/images/CConstImage.h"
#include "DGtal/base/ConstAlias.h"
//////////////////////////////////////////////////////////////////////////////

Expand All @@ -58,13 +58,13 @@ namespace DGtal
*
* This class is a model of CPointPredicate.
*
* @tparam Image an model of CImageContainer concept.
* @tparam Image an model of CConstImage concept.
*/
template <typename Image>
class SimpleThresholdForegroundPredicate
{
public:
BOOST_CONCEPT_ASSERT(( CImage<Image> ));
BOOST_CONCEPT_ASSERT(( CConstImage<Image> ));

typedef typename Image::Value Value;
typedef typename Image::Point Point;
Expand Down Expand Up @@ -95,14 +95,6 @@ namespace DGtal
return ( (*myImage)(*it) > myVal);
}

/**
* @return True if the point belongs to the value interval.
*/
bool operator()(const typename Image::Range::Iterator &it) const
{
return ( (*it) > myVal);
}

/**
* @return True if the point belongs to the value interval.
*/
Expand Down
2 changes: 1 addition & 1 deletion src/DGtal/images/imagesSetsUtils/SetFromImage.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
#include "DGtal/base/Common.h"
#include "DGtal/images/CImage.h"
#include "DGtal/kernel/sets/CDigitalSet.h"
#include "DGtal/images/imagesSetsUtils/IntervalForegroundPredicate.h"
#include "DGtal/images/IntervalForegroundPredicate.h"
//////////////////////////////////////////////////////////////////////////////

namespace DGtal
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
#include "DGtal/helpers/StdDefs.h"
#include "DGtal/shapes/ShapeFactory.h"
#include "DGtal/io/boards/Board2D.h"
#include "DGtal/images/imagesSetsUtils/SimpleThresholdForegroundPredicate.h"
#include "DGtal/images/SimpleThresholdForegroundPredicate.h"
///////////////////////////////////////////////////////////////////////////////

using namespace std;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
#include "DGtal/io/colormaps/HueShadeColorMap.h"
#include "DGtal/io/colormaps/GrayscaleColorMap.h"
#include "DGtal/io/boards/Board2D.h"
#include "DGtal/images/imagesSetsUtils/SimpleThresholdForegroundPredicate.h"
#include "DGtal/images/SimpleThresholdForegroundPredicate.h"
///////////////////////////////////////////////////////////////////////////////

using namespace std;
Expand Down
2 changes: 1 addition & 1 deletion tests/geometry/volumes/distance/testFMM.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
#include "DGtal/kernel/domains/DomainPredicate.h"
#include "DGtal/kernel/sets/DigitalSetFromMap.h"
#include "DGtal/images/ImageContainerBySTLMap.h"
#include "DGtal/images/imagesSetsUtils/SimpleThresholdForegroundPredicate.h"
#include "DGtal/images/SimpleThresholdForegroundPredicate.h"

//DT
#include "DGtal/images/ImageSelector.h"
Expand Down
2 changes: 1 addition & 1 deletion tests/geometry/volumes/distance/testReverseDT.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
#include "DGtal/io/colormaps/HueShadeColorMap.h"
#include "DGtal/kernel/sets/DigitalSetBySTLSet.h"
#include "DGtal/io/boards/Board2D.h"
#include "DGtal/images/imagesSetsUtils/SimpleThresholdForegroundPredicate.h"
#include "DGtal/images/SimpleThresholdForegroundPredicate.h"
///////////////////////////////////////////////////////////////////////////////

using namespace std;
Expand Down