Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display bug fixed for 3d StandardDSS (due to embedding) #854

Merged
merged 3 commits into from
Jul 7, 2014

Conversation

troussil
Copy link
Member

see #707

@troussil troussil added this to the 0.8 milestone Jun 26, 2014
@copyme
Copy link
Member

copyme commented Jun 26, 2014

Looks like problem still exists
bounding_box

@troussil
Copy link
Member Author

You're right.
A basic example where the display is not working is (0,0,0),
(0,1,0),(0,2,0),(0,2,1).
It seems that the computed direction vector is not correct in this
quadrant.

@dcoeurjo
Copy link
Member

dcoeurjo commented Jul 3, 2014

Is this PR ready now ? @copyme ? @troussil ?

@troussil
Copy link
Member Author

troussil commented Jul 3, 2014

Yes, it should be fine now.

2014-07-03 9:34 GMT+02:00 David Coeurjolly [email protected]:

Is this PR ready now ? @copyme https://github.com/copyme ? @troussil
https://github.com/troussil ?


Reply to this email directly or view it on GitHub
#854 (comment).

@copyme
Copy link
Member

copyme commented Jul 3, 2014

Green light. Works like a charm!
works

@dcoeurjo
Copy link
Member

dcoeurjo commented Jul 7, 2014

ok merging.

dcoeurjo added a commit that referenced this pull request Jul 7, 2014
display bug fixed for 3d StandardDSS (due to embedding)
@dcoeurjo dcoeurjo merged commit ce1f05b into DGtal-team:master Jul 7, 2014
@troussil troussil deleted the 3dDSSBugFix branch July 16, 2015 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants