Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rigid trans #869

Closed
wants to merge 37 commits into from
Closed

Rigid trans #869

wants to merge 37 commits into from

Conversation

copyme
Copy link
Member

@copyme copyme commented Jul 1, 2014

Could you review this code. Thanks!

@dcoeurjo
Copy link
Member

dcoeurjo commented Jul 2, 2014

cf travis build, some files are missing in your PR.

@copyme
Copy link
Member Author

copyme commented Jul 2, 2014

Should be fine right now.

dcoeurjo
dcoeurjo reviewed Jul 14, 2014
View reviewed changes
src/DGtal/images/RigidTransformation2D.h
* @see exampleRigidtransformation2d.cpp
*/
template <typename TPoint, typename TRealVector>
class ForwardRigidTransformation2D : std::unary_function <TPoint,TPoint>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please template the class by Space and get point/vector types from Space

@dcoeurjo
Copy link
Member

Ok thanks.

@dcoeurjo
Copy link
Member

Please have a look to travis, there are build issues.
If you have time, it would be nice to have a documentation package about that (even if it is just couple of snippets from the example files).. For instance, a moduleGeometricTransform in the Image package.

@copyme
Copy link
Member Author

copyme commented Jul 17, 2014

Looks like Travis failed because yesterday I changed something in a one test without rebuild. I was sure that should be fine.

I will write documentation today and also I will add a tools for rotation to DGtalTools.

@copyme
Copy link
Member Author

copyme commented Jul 17, 2014

OK I added a draft of doc. I will finish this tomorrow's morning.

@dcoeurjo
Copy link
Member

ok @copyme, thanks..
I have couple of doc edits and I'll do a pull-request to your branch. If you accept my PR, it will be automatically merged into this rotation branch. Thanks

@dcoeurjo
Copy link
Member

ok I'm closing this PR and create a new one.. thanks kacper.

@dcoeurjo dcoeurjo closed this Jul 25, 2014
@copyme copyme deleted the RigidTrans branch September 16, 2014 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@copyme @dcoeurjo