Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using ~0 instead of -1 as magic number for end(). #972

Merged
merged 2 commits into from
Mar 11, 2015
Merged

Using ~0 instead of -1 as magic number for end(). #972

merged 2 commits into from
Mar 11, 2015

Commits on Mar 10, 2015

  1. Using ~0 instead of -1 as magic number for end(). 

    Using -1 as magic number for unsigned int is implementation dependant.
~0 is a better choice and is type-size independant.
    @rolanddenis
    rolanddenis committed Mar 10, 2015
    Configuration menu
    Copy the full SHA
    4988580 View commit details
    Browse the repository at this point in the history

  2. Using std::numeric_limits<T>::max() instead of ~0 

    ... as magic number for end() iterator in Labels.
Also adding CUnsignedNumber and CIntegralNumber concept check for TWord
template parameter.
    @rolanddenis
    rolanddenis committed Mar 10, 2015
    Configuration menu
    Copy the full SHA
    0102a99 View commit details
    Browse the repository at this point in the history