Mesh copy with test #976
Merged
Mesh copy with test #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds ok... Could you please add a changelog entry? |
|
BTW : when adding a QuadFAce to a mesh (or polygon), what is the convention (CW of CCW) to have the normal vectors ok in OBJ viewers ? |
|
For the order it is CCW at least for OBJ, I add it to a note to the respecting method thank |
|
@dcoeurjo done. |
|
ok thanks. merging |
| @@ -54,6 +54,11 @@ | |||
| [#937](https://github.com/DGtal-team/DGtal/pull/937)) | |||
| - New methods to generate basic 3D tubular meshes and height fields. New mesh module documentation added. | |||
| (Bertrand Kerautret, [#969](https://github.com/DGtal-team/DGtal/pull/969)) | |||
| - Add of copy constructor and copy operator on Mesh object (and doc adds about vertex ordering for obj format). | |||
There was a problem hiding this comment.
doc adds -> documentation added
|
(sorry there are still minor typo in the changelog) |
|
Thanks that done;) |
|
Changes Unknown when pulling d56c6ae on kerautret:MeshCopyConstr into * on DGtal-team:master*. |
|
can we merge ? |
|
Yep.. doing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.