-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mesh voxelizer #279
add mesh voxelizer #279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new tools which work fine.
Just some typo and I also add a PR on your branch to include the link to the doc (else it will not be visible in the doc).
Please also add an entry in the Changelog ;)
converters/mesh2vol.cpp
Outdated
* @file mesh2vol.cpp | ||
* @ingroup converters | ||
* | ||
* @date 2016/09/28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure for the date ;)
converters/mesh2vol.cpp
Outdated
@code | ||
-h [ --help ] display this message | ||
-i [ --input ] arg mesh file (.off) | ||
-o [ --output ] arg filename of ouput voxelization file (.off) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.off => .vol and precise volumetric file like in source code ;)
converters/mesh2vol.cpp
Outdated
general_opt.add_options() | ||
("help,h", "display this message") | ||
("input,i", po::value<std::string>(), "mesh file (.off) " ) | ||
("output,o", po::value<std::string>(), "filename of ouput volumetric file (Vol,PGM3D,..).") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vol, pgm3d (lower case)
06ea1e2
to
2e3b577
Compare
@kerautret can I (or you) merge this one ? |
yes merging (I add just Monir Hadji as authors afterward on the master) |
👌 thx |
PR Description
CLI mesh voxelizer
c.f. DGtal-team/DGtal#1209
Checklist
cmake
mode (otherwise, Travis C.I. will fail).