Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mesh voxelizer #279

Merged
merged 13 commits into from
Feb 6, 2018
Merged

Conversation

hadjiszs
Copy link
Member

@hadjiszs hadjiszs commented Sep 30, 2016

PR Description

CLI mesh voxelizer

c.f. DGtal-team/DGtal#1209

Checklist

  • Doxygen documentation of the code completed (classes, methods, types, members...).
  • Main tool doxygen documentation (following existing documentation of DGtalTools documentation.
  • Check if it follows the tools structure described in CONTRIBUTING.md
  • New entry in the ChangeLog.md added.
  • Update the readme with potentially a screenshot of the tools if it applies.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).

Copy link
Member

@kerautret kerautret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new tools which work fine.
Just some typo and I also add a PR on your branch to include the link to the doc (else it will not be visible in the doc).
Please also add an entry in the Changelog ;)

* @file mesh2vol.cpp
* @ingroup converters
*
* @date 2016/09/28
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure for the date ;)

@code
-h [ --help ] display this message
-i [ --input ] arg mesh file (.off)
-o [ --output ] arg filename of ouput voxelization file (.off)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.off => .vol and precise volumetric file like in source code ;)

general_opt.add_options()
("help,h", "display this message")
("input,i", po::value<std::string>(), "mesh file (.off) " )
("output,o", po::value<std::string>(), "filename of ouput volumetric file (Vol,PGM3D,..).")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vol, pgm3d (lower case)

@dcoeurjo
Copy link
Member

dcoeurjo commented Feb 6, 2018

@kerautret can I (or you) merge this one ?

@kerautret
Copy link
Member

yes merging (I add just Monir Hadji as authors afterward on the master)

@kerautret kerautret merged commit e7e9701 into DGtal-team:master Feb 6, 2018
@dcoeurjo
Copy link
Member

dcoeurjo commented Feb 6, 2018

👌 thx

@hadjiszs hadjiszs deleted the 3dMeshVoxelization branch February 7, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants