Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load pdf from url use okhttp3 #366

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

shxdos
Copy link

@shxdos shxdos commented Jul 24, 2017

Add load pdf from url use okhttp3

@barteksc
Copy link
Collaborator

barteksc commented Jul 24, 2017

  1. Please use only english language
  2. Please reformat code
  3. You cannot use Environment.getExternalStorageDirectory() as is, current state must be checked with Environment.getExternalStorageState()
  4. You can extend existing sample, but not replace it
  5. Your sample does not work, because you have to ask user for WRITE_EXTERNAL_STORAGE permission starting with Android 6.0
  6. What will happen when configuration change occurs while downloading file?

@barteksc
Copy link
Collaborator

  1. PdfViewCache directory is never cleaned
  2. When you move app to background document stops downloading and becomes corrupted

@shxdos
Copy link
Author

shxdos commented Jul 25, 2017

@barteksc thanks

@supportreq
Copy link

Is it library working??

@mochadwi
Copy link

@barteksc @shxdos any updates for this?

@shubh261096
Copy link

@shxdos @barteksc Any update? because the library doesn't work for URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants