Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for nested scrolling in a CoordinatorLayout #827

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cilenco
Copy link

@Cilenco Cilenco commented Sep 26, 2019

It is disabled by default. You have to call setNestedScrollingEnabled(true) manually!

@AshishPaul
Copy link

@barteksc Hi, first of all, Thank you for this awesome library and the hard work you've put into this as well as other contributors.
I just wanted to know if this PR is going to get merged. I need this functionality in my app. Thanks to @Cilenco

polesapart added a commit to polesapart/AndroidPdfViewer that referenced this pull request Jul 10, 2020
@kartikj07
Copy link

Thank you soo much, @Cilenco this solution works great.

But when used with CollapsingToolbarLayout, the collapse works properly, but when the top of the PDF is reached the collapsed view doesn't start to reappear. Any ideas for it??

@akaita
Copy link

akaita commented Jul 1, 2021

This is in no way a replacement for a proper integration with CoordinatorLayout, but as a quick workaround I did:

pdfView.fromStream(myStream)
.onPageScroll { page, positionOffset ->
                            val topReached = page == 0 && positionOffset == 0f
                            appBarLayout.setExpanded(topReached, true)
                        }
.load()

Kinda does the trick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants