-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AndroidX migration #885
base: master
Are you sure you want to change the base?
AndroidX migration #885
Conversation
It seems like current AndroidPdfViewer library doesn't support an application migrated to androidX. Is it right? |
@katie0809 yeah, you are right. Here is a fork with AndroidX https://github.com/TalbotGooday/AndroidPdfViewer
|
@TalbotGooday Thank you, actually I solved problems by adding maven { url 'https://maven.google.com' } to the build.gradle. And I don't know why...='( |
@katie0809 so your problem was not the "migration problem") |
👍 look good to me :) @barteksc any chance to get this merged and forge a release? |
@TalbotGooday as there seems to be no update in this place, have you consider to continue your fork? |
@madmas it all depends on what desires the community will have) Feel free to create issues in my fork) |
@TalbotGooday thanks for the quick response :) |
@madmas oh, sorry. I will enable this option asap) UPD: Done |
Fix NPE in PdfView.loadComplete
Provided option to perform page snap without animation
The support library artifacts are being deprecated and all future development is going into AndroidX, so there’s no point to avoiding this migration.
UPD: Full-migrated library is here https://github.com/TalbotGooday/AndroidPdfViewer. It also includes some forks from this repo