Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dox fixes and move to python 3.7+ style #237

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Dox fixes and move to python 3.7+ style #237

merged 3 commits into from
Apr 21, 2022

Conversation

araffin
Copy link
Member

@araffin araffin commented Apr 21, 2022

Description

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

closes #236
closes #235

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

Note: we are using a maximum length of 127 characters per line

@araffin araffin merged commit 4b572bd into master Apr 21, 2022
@araffin araffin deleted the chore/fixes branch April 21, 2022 15:34
ernestum pushed a commit to HumanCompatibleAI/rl-baselines3-zoo that referenced this pull request Apr 29, 2022
@araffin @ernestum
Dox fixes and move to python 3.7+ style (DLR-RM#237)
217cf1f 
* Dox fixes and move to python 3.7+ style

* Fix type

* Fix broken packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@araffin