Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. config cache not cleared when the key is changed. #1339

Closed
Ninjaclasher opened this issue Apr 29, 2020 · 0 comments · Fixed by #1340
Closed

Misc. config cache not cleared when the key is changed. #1339

Ninjaclasher opened this issue Apr 29, 2020 · 0 comments · Fixed by #1340
Labels

Comments

@Ninjaclasher
Copy link
Member

Two possible fixes:

  1. The signal here is changed to a pre_save so the old instance can be retrieved. The cache should really be cleared based on the old key rather than the new key.
  2. Change the key to only be read-only in the admin page. However, this doesn't prevent the key from being changed from e.g. the Python shell, and the cache still won't be cleared properly in this case.
@kiritofeng kiritofeng added the bug label Apr 30, 2020
malbareda pushed a commit to malbareda/JOEL-web that referenced this issue Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants