Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot sort columns when tables are expanded #1105

Closed
stephaniesimms opened this issue Jan 30, 2018 · 4 comments
Closed

Cannot sort columns when tables are expanded #1105

stephaniesimms opened this issue Jan 30, 2018 · 4 comments
Assignees
Labels

Comments

@stephaniesimms
Copy link

stephaniesimms commented Jan 30, 2018

Paginated tables appear as expected, alphabetized by the first word in the first column. But if I click "View All" to expand the list the ordering gets shuffled (screenshot below). Then if I try to sort any of the columns, the table reverts back to a paginated view.

Desired behavior is to retain the original alphabetized order when a user clicks "View All". In addition a user should be able to sort columns while viewing the expanded list. There are only a few tables where the number of records is so large that this action will be slow (e.g. Super Admin tables of users or plans). We need to fix this to improve usability for the majority of users.

screen shot 2018-01-30 at 10 24 49 am

@sjDCC
Copy link
Contributor

sjDCC commented Feb 6, 2018

Happy for this to be done and if we find it has a big performance hit, we can rethink later.

The org users and plans tables are going to get quite long too so there may be more non-super-admin cases than we first expect.

@jollopre
Copy link
Contributor

jollopre commented Feb 7, 2018

This ticket will address:

  • Retain View All (if enabled) when sorting is requested
  • Add default sorting to paginable concern if no sorting request is made

jollopre pushed a commit to DigitalCurationCentre/roadmap that referenced this issue Feb 20, 2018
…w right aligned within the th. DMPRoadmap#1105

default sorting to paginable concern specified through query_params keyword. DMPRoadmap#1105

paginable plans including default sorting

paginable orgs including default sorting. DMPRoadmap#1105
@jollopre jollopre mentioned this issue Feb 20, 2018
@stephaniesimms
Copy link
Author

stephaniesimms commented Feb 21, 2018

sorting is working beautifully for all tables now.

a word of caution for @sjDCC - as a Super Admin we can't 'View All' to expand the lists for Users and Orgs (these queries overload things and blow up the server). I created a post MVP bug issue to handle them separately #1186 . for now DO NOT try to View All for these tables as a Super Admin.

@sjDCC
Copy link
Contributor

sjDCC commented Feb 23, 2018

Noted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants