Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many redirections in Sign Up #1397

Closed
andresf01 opened this issue Apr 19, 2018 · 6 comments
Closed

Too many redirections in Sign Up #1397

andresf01 opened this issue Apr 19, 2018 · 6 comments
Assignees
Labels
bug effort-small less than 1/2 day of dev time

Comments

@andresf01
Copy link

Hi, I found a error while working on ORCID authentication. I'm working on v1.0.3 but It occurss too in last release.

Expected behaviour: Fill fields in sign_up page and successfull login

Actual behaviour: Too many redirections after sign up (user is created in db but not redirecto to plans)

Steps to reproduce: Sign up in dmproadmap/users/sign_up

@vyruss
Copy link
Contributor

vyruss commented Apr 19, 2018

@andresf01 sorry, I don't understand, are you trying to:

  1. Login via ORCID ->
  2. The system tells you your ORCID login is not known and asks you to ->
    1. Link your existing account or
    2. Create a new account
  3. You create a new account ->
    1. This logs you in but your new account is not linked to the ORCID you used or
    2. This doesn't log you in and produces the too many redirections error

@andresf01
Copy link
Author

andresf01 commented Apr 19, 2018

Sorry @vyruss , the problem is that if I want to sign up via dmproadmap/users/sign_up route, application has too many redirections, although user is registered in database.

@vyruss
Copy link
Contributor

vyruss commented Apr 19, 2018

@andresf01 I cannot replicate this, would you be able to share some Rails logs? That may give us some clues.

@andresf01
Copy link
Author

@vyruss sure, https://codeshare.io/5QAk7R

@vyruss vyruss mentioned this issue Apr 20, 2018
@vyruss vyruss self-assigned this Apr 20, 2018
@vyruss
Copy link
Contributor

vyruss commented Apr 20, 2018

@andresf01 we spotted what was going wrong and #1400 should fix it

@vyruss vyruss added bug effort-small less than 1/2 day of dev time labels Apr 20, 2018
vyruss pushed a commit to DigitalCurationCentre/roadmap that referenced this issue Apr 20, 2018
* after_sign_in|up : Check for paths not urls (so that it works on localhost/http)
* remove duplicate IDs from sign_up page by not including it in modal too (related to DMPRoadmap#1064)
@andresf01
Copy link
Author

@vyruss Sign up is working now, issue could be close

xsrust pushed a commit to DigitalCurationCentre/roadmap that referenced this issue Jun 14, 2018
* after_sign_in|up : Check for paths not urls (so that it works on localhost/http)
* remove duplicate IDs from sign_up page by not including it in modal too (related to DMPRoadmap#1064)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug effort-small less than 1/2 day of dev time
Projects
None yet
Development

No branches or pull requests

2 participants