Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS compatibilities for IE #1429

Closed
jollopre opened this issue Apr 30, 2018 · 3 comments
Closed

JS compatibilities for IE #1429

jollopre opened this issue Apr 30, 2018 · 3 comments
Assignees
@jollopre
Labels
effort-medium 1/2 to 1 day of dev time

Comments

@jollopre
Copy link
Contributor

Since we are providing support for IE, we have to make sure that any JS function we use, has compatibility with IE. I came across with two functions that are not supported by IE and therefore prevent seeing the usage stats:

  • Object.assign (can be replaced with $.extend)
  • Array.prototype.fill (can be replaces with a polyfill, if used a lot)

Every JS has to be inspected in order to detect potential functions not supported by IE.
@jollopre jollopre added the effort-medium 1/2 to 1 day of dev time label Apr 30, 2018
@dsisu
Copy link

dsisu commented Apr 30, 2018

Comments are still not saving when editing via Internet Explorer. May be related to this issue.

@dsisu dsisu closed this as completed Apr 30, 2018
@dsisu dsisu reopened this Apr 30, 2018
@jollopre jollopre self-assigned this Apr 30, 2018
jollopre pushed a commit to DigitalCurationCentre/roadmap that referenced this issue May 1, 2018
polyfill for Array.prototype.find for IE. DMPRoadmap#1429
1fc26bd 
usage/index.js replaced Object.assign, Array.prototype.fill and Array.prototype.findIndex using $.extend, [] and Array.prototype.find respectively. DMPRoadmap#1429

tinymce styles moved to public/stylesheets. DMPRoadmap#1429
@jollopre jollopre mentioned this issue May 1, 2018
Merged
@vyruss
Copy link
Contributor

vyruss commented May 1, 2018

Tested working on DMPonline

@stephaniesimms
Copy link

all working as expected on roadmap stage. closing issue.

This was referenced May 9, 2018
Merged
Merged
xsrust pushed a commit to DigitalCurationCentre/roadmap that referenced this issue Jun 14, 2018
@xsrust
polyfill for Array.prototype.find for IE. DMPRoadmap#1429
6efaeb4 
usage/index.js replaced Object.assign, Array.prototype.fill and Array.prototype.findIndex using $.extend, [] and Array.prototype.find respectively. DMPRoadmap#1429

tinymce styles moved to public/stylesheets. DMPRoadmap#1429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jollopre jollopre

Labels
effort-medium 1/2 to 1 day of dev time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dsisu @jollopre @stephaniesimms @vyruss