Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include link to plan in Request feedback email #1431

Closed
rosiehigman opened this issue Apr 30, 2018 · 5 comments
Closed

Include link to plan in Request feedback email #1431

rosiehigman opened this issue Apr 30, 2018 · 5 comments
Assignees
@Bodacious
Labels
effort-small less than 1/2 day of dev time plans suggestion

Comments

@rosiehigman
Copy link

Expected behaviour:
When an Org Admin receives an email requesting feedback on a DMP it would be really helpful if that automated email could include a direct link to the plan in question.

Actual behaviour:
Org Admin has to go through all plans where reviews have been requested on the plan menu

Steps to reproduce:
Request a review as an Org Admin
requestfeedbackemail
@vyruss vyruss added plans suggestion effort-small less than 1/2 day of dev time labels May 1, 2018
@stephaniesimms stephaniesimms added effort-small less than 1/2 day of dev time and removed effort-small less than 1/2 day of dev time labels May 1, 2018
@stephaniesimms
Copy link

confirmed w/ @briri that this is technically possible and straightforward. placing in backlog.

@stephaniesimms stephaniesimms changed the title Review request email does not contain link to plan Include link to plan in Review request email May 21, 2018
@stephaniesimms stephaniesimms changed the title Include link to plan in Review request email Include link to plan in Request feedback email May 21, 2018
@Bodacious Bodacious self-assigned this Jul 4, 2018
Bodacious added a commit that referenced this issue Jul 4, 2018
@Bodacious
Add Plan URL to feedback notification email.
2e72389 
Issue #1431
@Bodacious Bodacious mentioned this issue Jul 4, 2018
Merged
@Bodacious Bodacious mentioned this issue Jul 4, 2018
Merged
@sjDCC
Copy link
Contributor

sjDCC commented Jul 9, 2018 •
edited
Loading

Looks good, thanks @Bodacious Have included a screengrab of the email here @stephaniesimms so you can double check quickly too.

email

@sjDCC sjDCC closed this as completed Jul 9, 2018
@stephaniesimms
Copy link

tested and all looks good.

briri pushed a commit to CDLUC3/dmptool that referenced this issue Jul 17, 2018
@Bodacious @briri
Add Plan URL to feedback notification email.
17d5a48 
Issue DMPRoadmap#1431
@briri
Copy link
Contributor

briri commented Jul 17, 2018

Reopening for verification after git cherry-pick

@briri briri reopened this Jul 17, 2018
@stephaniesimms
Copy link

links are present and working as expected. closing again.

briri pushed a commit to CDLUC3/dmptool that referenced this issue Jul 19, 2018
@Bodacious @briri
Add Plan URL to feedback notification email.
a41edce 
Issue DMPRoadmap#1431
briri pushed a commit to CDLUC3/dmptool that referenced this issue Nov 22, 2022
@Bodacious @briri
Add Plan URL to feedback notification email.
5856b86 
Issue DMPRoadmap#1431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bodacious Bodacious

Labels
effort-small less than 1/2 day of dev time plans suggestion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Bodacious @briri @sjDCC @stephaniesimms @rosiehigman @vyruss