Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to an Organization's Shibboleth identifier does not save #2288

Closed
briri opened this issue Nov 27, 2019 · 4 comments · Fixed by #2728
Closed

Changes to an Organization's Shibboleth identifier does not save #2288

briri opened this issue Nov 27, 2019 · 4 comments · Fixed by #2728
Assignees
Labels

Comments

@briri
Copy link
Contributor

briri commented Nov 27, 2019

Please complete the following fields as applicable:

This was discovered in the DMPTool issue260. It is only applicable to installations that filter the list of organisations that can be used for institutional login (as opposed to directing the user to a federation's organisation selector)

Expected behaviour:
When an application has the shibboleth_use_filtered_discovery_service in their config/application.rb set to true, the super admin's 'Edit Organization' page displays a 'Shibboleth entity id' and 'Shibboleth domain' field.
You should be able to change these values multiple times.

Actual behaviour:
The initial entries into these fields are properly saved, but any subsequent changes do not get saved.

Steps to reproduce:

  • Make sure your config/application.rb shibboleth_use_filtered_discovery_service is set to true. (requires a restart of the application)
  • Login as a super admin
  • Navigate to the Admin -> Organisations page
  • Edit one of your organizations
  • Add an entry into the Shibboleth fields and save
  • Try to change these values and click save (you will receive a success message but the Ship fields will retain their original value
@sjDCC
Copy link
Contributor

sjDCC commented Dec 2, 2019

One for you to test @mariapraetzellis

@briri
Copy link
Contributor Author

briri commented Dec 3, 2019

this appears to be working now.

@mariapraetzellis is out until Friday so am going to close so that we can get the release out. Will reopen a new ticket if necessary

@briri briri closed this as completed Dec 3, 2019
@mariapraetzellis
Copy link

Looks like this bug is back. When trying to edit the Shibboleth - entityID changes are not saved when I navigate back to the page.

@mariapraetzellis
Copy link

Confirming that I can now edit shib info successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants