Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue with saving an Organization's shibboleth identifiers #2289

Merged
merged 2 commits into from
Nov 28, 2019
Merged

Fixes issue with saving an Organization's shibboleth identifiers #2289

merged 2 commits into from
Nov 28, 2019

Conversation

briri
Copy link
Contributor

@briri briri commented Nov 27, 2019

Fixes #2288

Changes proposed in this PR:

  • Reworked save logic. The original was only allowing the 'create' and 'destroy' for an org_identifier.
  • Also updated the placeholder text to display both the 'https://my-org.edu' and 'urn:mace:incommon:my-org' style Shibboleth entityIDs

xsrust
xsrust approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@xsrust xsrust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good.
We don't use the filtered discovery service, so you'll need to test on dmptool-staging

@xsrust xsrust merged commit da5d3ff into development Nov 28, 2019
@briri briri deleted the issue2288 branch December 9, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsrust xsrust xsrust approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briri @xsrust