Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org selection is not calling out to the external ROR API #2746

Closed
briri opened this issue Nov 25, 2020 · 2 comments · Fixed by #2747
Closed

Org selection is not calling out to the external ROR API #2746

briri opened this issue Nov 25, 2020 · 2 comments · Fixed by #2747
Assignees
Labels

Comments

@briri
Copy link
Contributor

briri commented Nov 25, 2020

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)
v3.0

Expected behaviour:
When you type in the 'Organisation' typeahead box on the 'Create Account' form it should search the local DB for results and call out to the ROR API

Actual behaviour:
It only checks the local DB

This appears to be related to the switch over to Strong Params during the Rails 5 upgrade. The incoming data in the POST come through as:

Processing by OrgsController#search as */*
  Parameters: {"org"=>{"name"=>"National"}, "funder_only"=>"false", "type"=>"combined"}

But the controller is expecting the :funder_only and :type to be encapsulated in the Strong Params: {"org"=>{"name"=>"National","funder_only"=>"false","type"=>"combined"}

@pherterich
Copy link

Works for me - looks initially at the local institutions I'd expect to show up and then comes up with a very long list from ROR.

@mariapraetzellis
Copy link

When searching for orgs in the contributors tab I'm seeing orgs not already in the db, so can confirm that it is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants