Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Org selection dropdowns #2747

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Fix for Org selection dropdowns #2747

merged 3 commits into from
Dec 1, 2020

Conversation

briri
Copy link
Contributor

@briri briri commented Nov 25, 2020

Fixes #2746.

Changes proposed in this PR:

  • Update controller to fetch the funder_only and type parameters from params instead of the Strong params that are encapsulating the search term/org name
  • Update tests to mimic reality

@xsrust xsrust merged commit 0762c4e into master Dec 1, 2020
@briri briri deleted the org-search-fix branch December 18, 2020 17:00
portagenetwork pushed a commit to portagenetwork/roadmap that referenced this pull request Feb 24, 2022
* fix for issue with Org selection. Strong params were always resulting in local DB search

* updated tests to catch future issues with org selection

* fixed Rubocop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Org selection is not calling out to the external ROR API
2 participants