Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can you create a plan from a publicly visible template when not logged in? #2804

Closed
nicolasfranck opened this issue Feb 3, 2021 · 1 comment

Comments

@nicolasfranck
Copy link
Contributor

Please complete the following fields as applicable:

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)

3.0.1

What happens:

When you access the page /public_templates,
it not only lists the public templates from which you
can create a new plan in one click, it always shows
a "create plan" link. But that link cannot work if
you are not logged in. Better remove it if not logged in?

@nicolasfranck nicolasfranck changed the title can you create a plan from a publicly visible template? can you create a plan from a publicly visible template when not logged in? Feb 3, 2021
@briri
Copy link
Contributor

briri commented Feb 3, 2021

Yes, good catch @nicolasfranck!

I think a check with the user_signed_in? Devise helper method should work here. If you have a chance can you submit a PR? We hope to create a new release over the next few weeks and it would be good to include this patch. Thank you!

briri added a commit that referenced this issue Feb 4, 2021
fix issue #2804: hide link to create plan, when not logged in
@briri briri closed this as completed Mar 12, 2021
portagenetwork pushed a commit to portagenetwork/roadmap that referenced this issue Feb 24, 2022
portagenetwork pushed a commit to portagenetwork/roadmap that referenced this issue Feb 24, 2022
fix issue DMPRoadmap#2804: hide link to create plan, when not logged in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants