Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise plan Download (formerly Export) page #498

Closed
stephaniesimms opened this issue Jul 5, 2017 · 15 comments
Closed

Revise plan Download (formerly Export) page #498

stephaniesimms opened this issue Jul 5, 2017 · 15 comments
Assignees

Comments

@stephaniesimms
Copy link

stephaniesimms commented Jul 5, 2017

UX wireframes @JEK-III : http://h90c3m.axshare.com/#g=1&p=write_plan
Functional Specification (global spec for all write plan pages): Implement with a non-table layout; attach labels to input fields
Related issues for write plan pages #491 #494 #495 #497

  • Tab renamed "Download"
  • Button renamed "Download Plan"
  • Replace included elements options w/new, abbreviated menu of options; blue notepad w/functional specs - Fieldset legend for checkboxes
  • by default export all answers (no tickbox for this)
  • Project Details encompasses all info captured on Project Details page (still to-do - coversheet design for this info, related to Create cover page for Public DMPs PDFs #436)
  • note functional spec for when/how to display unanswered questions tickbox
  • add tooltip beside supplemental sections tickbox
  • set default to most common file format (assuming PDF @sjDCC ? if not PDF most likely DOCX)
@briri
Copy link
Contributor

briri commented Jul 7, 2017

@JEK-III there is no message displayed when I click on the blue notepad icon next to the supplemental sections checkbox. Are 'supplemental sections' customized sections of a funder template? If so should this checkbox be hidden when the plan does not have customized sections?

Follow the form-fieldset pattern found on the edit plan details page.

Use the following format for the tooltip button next to the supplemental sections checkbox. there is generic JS wiring that will recognize the data-toggle="popover" attribute:

<a href="#" data-toggle="popover" rel: "popover" data-html: "true" role="button" 
             data-content="<%= _('Here's our helpful message') %>" 
             aria-label="<%= _('More information: Supplemental sections') %>">
<span class="fa fa-question-circle" aria-hidden="true"></span></a>

Update export file to adhere to the new checkboxes (e.g. skip the coversheet if the box is not checked, etc.)

@xsrust xsrust self-assigned this Jul 13, 2017
@xsrust
Copy link
Contributor

xsrust commented Jul 13, 2017

@JEK-III
As brian mentioned above, the notepad icon next to supplemental sections is blank. Is the intended behavior to hide customized sections, and only display on customized templates?

Additionally, how are plans with multiple phases supposed to be handled? I dont know of any with more than 3 phases in the current dataset. Perhaps this could be a drop-down box which appears when the plan has multiple phases?

@JEK-III
Copy link

JEK-III commented Jul 13, 2017

@xsrust
The intended behavior is to only show that checkbox on customized templates. I adjusted the way elements are layered in the wireframe so the annotation should work now.

As far as multi-phase templates go, I see nothing wrong with the current approach of having separate tabs for each phase, labelled with the name of the phase. (In which case there will be no tab labeled "write plan")

@xsrust
Copy link
Contributor

xsrust commented Jul 14, 2017

@JEK-III Thanks for that. The wireframe looks good to me on the guidance/annotation front.

The question I intended to ask was about the download page with multiple pages. The current behavior is to export only one phase at a time, since phases represent multiple stages in an application. The wireframe on the Downloads page does not have any way to select which phase should be downloaded.

@stephaniesimms
Copy link
Author

@xsrust raises a good point. @JEK-III - can you add a phase selector to the download options? this would only appear for templates w/multiple phases (eg H2020) and ideally include the specific phase names.

@JEK-III
Copy link

JEK-III commented Jul 14, 2017

@xsrust Got it– I added a phase droplist to the download panel.

@xsrust
Copy link
Contributor

xsrust commented Jul 17, 2017

Thanks @JEK-III

@vyruss
Copy link
Contributor

vyruss commented Jul 19, 2017

Tagging issues #154 and #346 because relevant code will affect them in the future

@sjDCC
Copy link
Contributor

sjDCC commented Jul 21, 2017

The select phase to download works fine. You can only select one at a time, whereas I think we are exporting all 'complete' phases for the public DMPs page. I guess we don't need to let users export multiple at once though. What do you think @stephaniesimms?

A couple of suggestions:

  • the 'questions as headings' concept is a difficult one to grasp. Could we rephrase this to "full question text as well as section headings"
  • change 'supplimental section(s)...' to 'supplementary section(s)...'

There are a couple of places where we could do with extra spacing e.g. before 'format' or better alignment e.g. the phase and format select boxes and thinks out of line
download

@stephaniesimms
Copy link
Author

I imagine users will only want to download one phase at a time - but we can do usability testing for this page to confirm. I second @sjDCC suggestions for rephrasing:

  • the 'questions as headings' concept is a difficult one to grasp. Could we rephrase this to "full question text and section headings"
  • change 'supplimental section(s)...' to 'supplementary section(s)...'

@sjDCC
Copy link
Contributor

sjDCC commented Jul 25, 2017

Yeah, I suspect likewise that users will only want to download one phase at a time. Main use case for multiple phases at once is our auto-export for public DMPs

@JEK-III
Copy link

JEK-III commented Jul 25, 2017

Wireframes updated.

FWIW I don't see any problem with adding an "all phases" option to the dropdown menu if we decide at some point that it would be useful.

@sjDCC
Copy link
Contributor

sjDCC commented Jul 25, 2017

Perfect, thanks @JEK-III

Like Steph, I don't expect there be much demand but having an all phases option in the dropdown is a sensible fix

@stephaniesimms
Copy link
Author

@xsrust - wireframe is updated w/small text changes for Optional plan components. that should be the final tidbit for this issue.
screen shot 2017-07-27 at 10 27 04 am

@briri
Copy link
Contributor

briri commented Oct 19, 2017

closing. All of the work on this one is complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants