Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated iterator on admin_template page to remove nil access errors #1032

Merged
merged 1 commit into from
Jan 16, 2018

Conversation

xsrust
Copy link
Contributor

@xsrust xsrust commented Jan 11, 2018

Fixes a bug where a template would not display.

The user had deleted phase 1 but kept 2,3 this caused a nil error with the old iterator. Fixed by iterating over the sorted list of keys from the hash

NOTE:
This is a bugfix to be applied to Master & any live services.

Copy link
Contributor

@briri briri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @xsrust. Leaving it for someone on the DCC side to merge though and create the new production release so that you can coordinate deploying to your production servers.

@jollopre jollopre merged commit 1e94a1e into DMPRoadmap:master Jan 16, 2018
@DigitalCurationCentre DigitalCurationCentre deleted the templates_bugfix branch March 12, 2018 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants