Issue 1186 #1325
Merged
Issue 1186 #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jollopre
commented
Mar 26, 2018
jollopre
commented
- paginable_base_url_with_query_params using double splat. paginable method instead of local variable. Clicking 'View All' for Users and Orgs as Super Admin blows up server #1186
- view_all option for paginable_renderise method in order to restrict access to ALL data from a scope. Clicking 'View All' for Users and Orgs as Super Admin blows up server #1186
- fixed integration tests to accommodate the view_all option. Clicking 'View All' for Users and Orgs as Super Admin blows up server #1186
…thod instead of local variable. DMPRoadmap#1186 view_all option for paginable_renderise method in order to restrict access to ALL data from a scope. DMPRoadmap#1186 fixed integration tests to accommodate the view_all option. DMPRoadmap#1186
|
looks good @jollopre. Nice use of Ruby's splat argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.