Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed requirement that users are confirmed from stats controller #1414

Merged
merged 1 commit into from
Apr 25, 2018
Merged

removed requirement that users are confirmed from stats controller #1414

merged 1 commit into from
Apr 25, 2018

Conversation

xsrust
Copy link
Contributor

@xsrust xsrust commented Apr 25, 2018

Fixes #1410 .

Changes proposed in this PR:

  • update statstics API to consider users who have not confirmed their account to show up in the API.
  • Previous change to login logic allows users who are unconfirmed to log in, so they should appear in the API

NOTE:
We should rebase development, contributions, and sprint2 branches after merging this as they are out of date
We should also create a release to capture these changes to master

briri
briri approved these changes Apr 25, 2018
View reviewed changes
Copy link
Contributor

@briri briri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@briri briri merged commit 3fa752b into DMPRoadmap:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briri briri briri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xsrust @briri