updated guidance on only display once per question. Added break betw… #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en individual guidances
Bodacious
reviewed
Aug 21, 2018
| <%= theme.title %> | ||
| <i class="fa fa-plus pull-right" aria-hidden="true"></i> | ||
| </h2> | ||
| <% if (guidances.map{|g| g.id} - guidances_output).any? # any not output%> |
There was a problem hiding this comment.
-
Can you move the comment to above the line please? (Trying to stay strict to the style guide)
-
Suggested minor refactor:
guidances.map(&:id)
There was a problem hiding this comment.
addded the comment above and updated the statement.
I need to get in the habit of using the &:
|
The broken tests should be fixed once #1832 is merged in. This broken test bug was caused by a combination of refactoring how Languages are loaded and the cache suite being added. |
Bodacious
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1755
only output each guidance once per question.
Also adds separation between individual guidance when output within the same theme