Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Usage page display to fix several issues. #2082

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Conversation

johnpinto1
Copy link
Contributor

@johnpinto1 johnpinto1 commented Apr 12, 2019

    - Moved mouse pointer instruction.
    - Made textual changes to "No. of plans by template"
    - The bar charts for  "No. users joined during last year" and
    "No. plans during last year" months are in ascending order. They were
    in descending order previously. Updated the count statistics methods
    in statistics_controller.rb.
    - The "No. plans by template" bar chart is now  replaced by a stacked bar chart
    as this is visually better for large data.
    - updated the by_template method in the create_or_update.rb with code from @xsrust.
    This now aggregates template counts for a month correctly.

    Fix for issue #1679.

There is an issue with discrepancies in plan numbers between "No. of plans by template" and "No. users joined during last year" which I will raised an issue about this #2083.

@johnpinto1
Copy link
Contributor Author

Will fix Travis errors.

@johnpinto1 johnpinto1 force-pushed the issue1679 branch 3 times, most recently from 2d63c3b to 86ba0a5 Compare April 12, 2019 13:31
    - Moved mouse pointer instruction.
    - Made textual changes to "No. of plans by template"
    - The bar charts for  "No. users joined during last year" and
    "No. plans during last year" months are in ascending order. They were
    in descending order previously. Updated the count statistics methods
    in statistics_controller.rb.
    - The "No. plans by template" bar chart is now  replaced by a stacked bar chart
    as this is visually better for large data.
    - updated the by_template method in the create_or_update.rb with code from @xsrust.
    This now aggregates template counts for a month correctly.

    Fix for issue #1679.
@johnpinto1
Copy link
Contributor Author

Updated to fix Travis errors.

Copy link
Contributor

@briri briri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good @johnpinto1

@briri briri merged commit 06fd2b1 into development Apr 12, 2019
@briri briri deleted the issue1679 branch December 9, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants