Rails5 ajax fixes

[briri]

• Updated application.js to share Rails UJS with our custom JS and JS.ERB files
• Fixed up the pagination concern, js, controllers and views to use strong params and to render JSON when the user has interacted with the pagination, sorting or searching functionality

@raycarrick-ed note that in order for a scenario where we were programmatically calling .submit for a form, we now should use Rails.fire(form[0], 'submit'); (where form is the JQuery element). I found this fix in this article: https://stackoverflow.com/questions/12683524/with-rails-ujs-how-to-submit-a-remote-form-from-a-function

[raycarrick-ed]

Looks fine to me. It's quite a lot of change in how we handle the AJAX specially.

[briri]

@raycarrick-ed @xsrust lets hold off on this one. I'm going to play around some more with it to see if starting rails ujs in the packs/application.js is behind our puma issues. These scenarios where we do a form submit through JS may be good candidates for switching over to the js.erb approach (for these specific situations)

[briri]

ok @raycarrick-ed and @xsrust I think I may have stumbled upon the puma hanging issue. I noticed that it was trying to load the JSON file for the ResearchProjectsController which uses the Rails cache and the Thread library. When I commented out the 'Thread' bit things started puma stopped hanging.

That JSON load may be a good candidate for ActionCable's web-socket functionality. Something to investigate down the road I guess.

This PR should be good to go. Note that I enabled Turbolinks. I think now that we have a handle on the Ajax UJS issue that we can enable it again.

I went through more of the pages and fixed up the ajax. Note the checkboxes on the Plans page and Users page which were previously checkboxes wrapped inside a form. This are now just 'remote' checkboxes and I had to add authenticity_token: true to get it to pass that token along to the controller.

[briri]

ok some final commits on this one @raycarrick-ed and @xsrust. I fixed up all of the tests broken by adding the optional: true to model associations and also addressed #1974 (make timeago localized). Also made some minor tweaks to get the feature specs working (except for the templates/annotations ones which should start working once @raycarrick-ed updates for the JS on those pages is merged in)

I had to re-disable turbolinks in the application.js

[briri]

switch to ||=

[briri]

switch to pass auth token

[briri]

create ticket to investigate this