Provide admins with a way to regenerate their API token #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… separate profile tab
…efinition in initializer
xsrust
suggested changes
Nov 10, 2020
Comment on lines
+96
to
+102
| // Setup JS functions/libraries so that they're available within the js.erb templates | ||
| window.$ = jQuery; | ||
| window.jQuery = jQuery; | ||
|
|
||
| // Allow js.erb files to access the notificationHelper functions | ||
| window.renderAlert = renderAlert; | ||
| window.renderNotice = renderNotice; |
There was a problem hiding this comment.
I'll need to make a mental-note this is how you can expose stuff like jQuery.
Thanks for getting this hooked up
app/policies/user_policy.rb
Outdated
Comment on lines
62
to
64
| def refresh_token? | ||
| true | ||
| end |
There was a problem hiding this comment.
Do we want to validate that the user has either permission to use the API or an existing API token?
There was a problem hiding this comment.
Yes, the button should not appear unless they're an Org admin but it would make sense to add logic to the policy
| <%# TODO: replace this with the notificationHelper.js once we move to Rails 5 %> | ||
| var notification = document.getElementById("notification-area"); | ||
| notification.append(msg); | ||
| notification.classList.remove('hide'); No newline at end of file | ||
| renderNotice(msg); |
There was a problem hiding this comment.
Great to see these TODO's going away:)
|
Ok @xsrust I added some permission checks to that policy |
portagenetwork
pushed a commit
to portagenetwork/roadmap
that referenced
this pull request
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2410 .
Added ability for user to regenerate their own API token (or create one if it was not initialized for some reason when they became an Org admin). Also updated the application.js to make jQuery and the notificationHelper functions available within the js.erb files.
Changes proposed in this PR: