Update google analytics config #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note you'll need to merge the ISSUE_TEMPLATE.md PR first as it has the fixes for the GitHub Workflows. Then you should be able to rebase afterward to pull in those fixes. |
xsrust
approved these changes
Nov 23, 2020
portagenetwork
pushed a commit
to portagenetwork/roadmap
that referenced
this pull request
Feb 24, 2022
Co-authored-by: Sam Rust <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to mention this one in our meeting today. The
config/initializers/_dmproadmap.rbfile has the Google Analytics tracker variable as:config.x.tracker_root = ""but it is referenced asRails.configuration.x.google_analytics.tracker_rootin the code.Just updating the example in this PR to add the missing
google_analyticsnamespace. Be sure to check your deployments to make sure they are using the correct name.