Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with investigator and data_Contact info for API v0 #2892

Merged
merged 2 commits into from
May 6, 2021

Conversation

briri
Copy link
Contributor

@briri briri commented May 5, 2021

Fixes #2870.

Changes proposed in this PR:

  • We moved the investigator and data_contact info from the plans table to the contributors table. The JSON was trying to display the investigator and data_contact info even if none had been defined for the plan which was resulting in an error due to undefined method on a nil object

@raycarrick-ed this was the error reported for me in the DMPTool (ours has the same issue but we have no one actively using v0). I am unsure if it is the same for your installations.

@briri briri requested a review from raycarrick-ed May 5, 2021 20:53
Copy link
Contributor

@raycarrick-ed raycarrick-ed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of us having issues with this but it looks safer.

@raycarrick-ed raycarrick-ed merged commit bc32927 into master May 6, 2021
@briri briri deleted the fix-api-v0-issue branch September 8, 2021 21:31
portagenetwork pushed a commit to portagenetwork/roadmap that referenced this pull request Feb 24, 2022
fix issue with investigator and data_Contact info for API v0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API - issue reported by the user for API v0 and V1
2 participants