IssueID #629 - Fix to allow API Access tab visible on the users's "Edit #3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rubocop errors don't seem related to my changes. |
|
I would think that a user who only has Yes, the rubocop errors are unrelated to your changes. We are in the process of upgrading to the latest version. |
other Org Admin privileges not set." Changes: - Replaced @user.can_org_admin? (in tests for display of API Access tab and content) with @user.can_use_api?. This insures that tabs visible in case it was failing.
johnpinto1
force-pushed
the
bug_629_granting_API_use_rights_not_working
branch
from
c98f3d0
to
2b481a1
Compare
|
rubocop failures are a known issue that we're working on in another branch |
nicolasfranck
added a commit
to DMPbelgium/roadmap
that referenced
this pull request
Jan 12, 2022
nicolasfranck
added a commit
to DMPbelgium/roadmap
that referenced
this pull request
Feb 28, 2022
nicolasfranck
added a commit
to DMPbelgium/roadmap
that referenced
this pull request
Jun 1, 2023
nicolasfranck
added a commit
to DMPbelgium/roadmap
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for DCC bug https://github.com/DigitalCurationCentre/DMPonline-Service/issues/629
Fix for "Granting API use rights does not work if other Org Admin privileges not set."
@briri & @raycarrick-ed Updated code based on comment #3047 (comment) . The Admin menu is now only visible when @user.can_org_admin? condition is satisfied, which will not be the case if the user is only granted API access.