DCC Issue 679 - Fix for issue that Super Admins unable to create new

[johnpinto1]

Orgs.

Fix for DCC issue https://github.com/DigitalCurationCentre/DMPonline-Service/issues/679

Changes:

• in app/controllers/super_admin/orgs_controller.rb added missing params
  to orgs_params method
  :funder, :institution, :organisation
• in app/models/org.rb removed (as it is never set on Org creation)
  validates :abbreviation, presence: { message: PRESENCE_MESSAGE }
• in app/views/orgs/_profile_form.html.erb removed :abbreviation required
  "aria-required": true
• in app/views/shared/org_selectors/_external_only.html.erb renamed wrongly named text field :org_name to :name
  <%= form.label :name, label %>
  <%= form.text_field :name, class: "form-control autocomplete",

[raycarrick-ed]

You have changes to _external_only which are not reflected in _combined or _local_only.
Is that right?
Without thinking about it a lot so I might be wrong, I'd have thought that they are interchangeable and so need to be equivalent.
So all returning org_name or all returning name.
Is that not the case?

[johnpinto1]

@raycarrick-ed will check based on above comment.

Well caught. Will check for :org_name elsewhere too and update.

[johnpinto1]

@raycarrick-ed looks like change in app/views/shared/org_selectors/_external_only.html.erb is not quite right. As lookup of orgs fail. Need to look into it as _combined or _local_only versions work correctly.

[johnpinto1]

@raycarrick-ed Switching RoR on affects following:
app/views/devise/registrations/_personal_details.html.erb
82: <%= render partial: "external_identifier",

app/views/orgs/_profile_form.html.erb
12: <%= render partial: "orgs/external_identifiers",
158: <%= render partial: "orgs/external_identifiers",

app/views/shared/org_selectors/_combined.html.erb
31: type: "combined",

app/views/shared/org_selectors/_combined.html.erb is used by:
app/views/super_admin/users/edit.html.erb
30: <%= render partial: "shared/org_selectors/combined",

The app/views/orgs/_profile_form.html.erb is the used in:

app/views/super_admin/orgs/new.html.erb
26: <%= render partial: 'orgs/profile_form',

app/views/orgs/_profile_form.html.erb
9: id: "edit_org_profile_form" } ) do |f| %>

app/views/orgs/admin_edit.html.erb
42: <%= render partial: 'orgs/profile_form',

app/views/devise/registrations/_personal_details.html.erb is used by:
app/views/devise/registrations/edit.html.erb
35: <%= render partial: 'devise/registrations/personal_details', locals: {orgs: @orgs, org_partial: @org_partial} %>

[briri]

looks ok to me @johnpinto1 that 'external_only' partial is only used on that one page so changing the param names will not negatively impact other portions of the site.