fixes for authorize after security breach Dec 2022 #3097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briri
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Looks good @raycarrick-ed. I think user_signed_in? would be a better check than @user.is_a?(User)
app/policies/plan_policy.rb
Outdated
| @@ -82,4 +86,12 @@ def update_guidances_list? | |||
| @plan.editable_by?(@user.id) | |||
| end | |||
|
|
|||
| def privately_visible? | |||
| @user.is_a?(User) | |||
There was a problem hiding this comment.
Do we want to change these 2 to user_signed_in?
There was a problem hiding this comment.
Yes. That's better.
|
thanks for cleaning these policies up! |
Helper user_signed_in? from devise isn't available in policy files. So using @user.present? instead which should be equivalent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DCC #682 .
Changes proposed in this PR: