DCC Bug #693 - Fix for pagination of plans retreived using the REST API V0 #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V0. Changes: - replaced wrongly named param :page_size with :per_page that is used in pagination in app/controllers/api/v0/base_controller.rb - added a before_action :page_params to app/controllers/api/v0/plans_controller.rb - added code to retreive :per_page param to scope in app/controllers/concerns/paginable.rb.
johnpinto1
force-pushed
the
bug_dcc_693_EUR-API1-V0-Plans-Pagination
branch
from
3134e27
to
2f068f8
Compare
|
@briri & @raycarrick-ed The test error is (nothing to do with changes): Failed examples: |
|
can confirm the error isn't related to the changes @johnpinto1 made. I fixed it by removing the trailing 's' on the token in that string. I can't wrap my head around why it wants a trailing 's' in some places and not others. The examples in thee rubocop docs appear to be contradictory: https://www.rubydoc.info/github/bbatsov/RuboCop/RuboCop/Cop/Style/FormatStringToken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for DCC Issue https://github.com/DigitalCurationCentre/DMPonline-Service/issues/693
Changes:
pagination in app/controllers/api/v0/base_controller.rb
app/controllers/concerns/paginable.rb.