-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to v4.0 #3226
Upgrade to v4.0 #3226
Conversation
plans details coversheet is ticked by default. Fix for issue #3063. Changes: - added a configurable property to # Check download of a plan coversheet tickbox config.x.plans.download_coversheet_tickbox_checked = false - use property to check "project details coversheet" by default or not if property set. If property is unset, the tickbox is unchecked.
…ct_sheet_tickbox_for_plan_downloads Feature #3063 - Feature to be able to configure whether the download
…variable due to Rails new middleware that prevents DNS rebinding by introducing a host whitelist
… for zeitwerk. Fixed some issues with the ContactUs controller because its constant name did not conform to Rails standards. removed Faker:Language helper because it did not conform to naming conventions and updated tests. Started trying to fix rspec tests
…t method is deprecated
add contributor to coversheet and add plan title to csv export
…eme_help do not repeat help instructions for every guidance group
Upgraded TinyMCE to V5
…veRecord::ConnectionNotEstablished exception The full error was ActiveRecord::ConnectionNotEstablished - No connection pool for 'ActiveRecord::Base' found for the 'other' role.
…rds filters in Research Output form
pluck with ampersand returns not id
…fierScheme prefix
Fix for issue #3217 regarding template search feature
Contributor form allows user to include whitespace at the beginning of ORCID
commented our Capybara.start
Fix/plan visibility
Translation.io new sync for rails6 25/10/2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good so far !
It might be good to add a warning for people using query methods with raw SQL. It's been deprecated since Rails 5.2 and removed in Rails 6
You can see an example (and a solution) here : https://medium.com/@mitsun.chieh/activerecord-relation-with-raw-sql-argument-returns-a-warning-exception-raising-8999f1b9898a
DMP OPIDoR is impacted because we're using JSON fields with queries on the JSON data.
For example :
.pluck("data->>'keyword'")
.order("data->>'lastName', data->>'firstName'")
thanks @benjaminfaure and @pengyin-shan I added a note to the |
Researchers
Administrators
Developers
This release includes a major upgrade of Rails (5.x to 6.1) and an upgrade from Ruby 2.6 to 2.7.6. Please review the following release notes as well as our upgrade guide and be aware that you will most likely need to adjust/modify any local customizations you may have made within your local fork of the code.
This release includes an upgrade from Ruby 2.6 to Ruby 2.7.6 and Rails 5.x to Rails 6.1!
You will need to do the following:
config/initializers/new_framework_defaults_6_1.rb
DMPROADMAP_HOST
environment variable. Rails 6+ introduces new middleware that helps mitigate DNS rebinding attacks. This includes a hostname whitelist. The value you assign to this environment variable will be added to the whitelist.SUPPORTED_LOCALES
CLIENT_LOCALES
andDEFAULT_LOCALE
in theconfig/initializers/translation.rb
for your instanceUpdates:
https://orcid.org// 0000-0000-0000-0000.
Contributor form allows user to include whitespace at the beginning of ORCID #3212update_attributes
withupdates
sinceupdate_attributes
was deprecatedJSONLinkValidator
class file toJsonLinkValidator
record.errors[:model] << 'foo'
torecord.errors.add(:model, 'foo')
config/environments/*.rb
files to use the newDMPROADMAP_HOST
environment variable to defined theRails.application.routes.default_url_options
and newconfig.hosts
setting.download_coversheet_tickbox_checked
flag to theconfig/initializers/_dmproadmap.rb
initializer that will default the Plans Download page to default that checkbox to be truedb/seeds.rb
file that is used for new installations so that it uses thefind_or_create_by
instead ofcreate!
to prevent duplicates when the DB already exists.