Fixes issue with bad join in Phase load #901
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rewrote Plans.load_for_phase query
We discovered that the join from the old query was not considering the plan when retrieving answers. This resulted in a query that returned - (question * ([all answers from any plan]). The page logic was only displaying the correct records but the query itself was causing significant page load times. Here is the query:
After further review it was also discovered that it was unnecessary to load the guidance_groups and associated guidance in this query since the controller loads it again afterward via the
Plan.guidance_groups
method