Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case 7.5 for MEASUREMENTS. #118

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Add test case 7.5 for MEASUREMENTS. #118

merged 1 commit into from
Nov 15, 2023

Conversation

Xiaohanjlll
Copy link
Contributor

fix: #117
fix: #112

@Xiaohanjlll Xiaohanjlll force-pushed the DMTFSpecMeasurementValueType branch 2 times, most recently from 7f46d09 to 80d1efd Compare November 10, 2023 07:32
jyao1
jyao1 reviewed Nov 13, 2023
View reviewed changes
doc/7.Measurements.md Outdated
@@ -277,6 +277,8 @@ Assertion 7.5.2:
Assertion 7.5.3:
if (SpdmMeasurementBlock[i].Measurement.DMTFSpecMeasurementValueType.bit_7 = 0) then (SpdmMeasurementBlock[i].Measurement.DMTFSpecMeasurementValueSize == HashSize)

Assertion 7.5.4:
When DMTFSpecMeasurementValueType[6:0]=0x5 , DMTFSpecMeasurementValueType[7] shall be set to 1b .
Copy link
Member

@jyao1 jyao1 Nov 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please leave a blank line. Follow the same style.

  2. Please use the same style for description, such as AAA == BBB, if CCC, or if () then (AAA == BBB)

  3. Please describe this is for 1.2 only, with same style as others.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. i have modified

@jyao1
Copy link
Member

jyao1 commented Nov 13, 2023

please show the test result.

@Xiaohanjlll Xiaohanjlll force-pushed the DMTFSpecMeasurementValueType branch 2 times, most recently from 9f972e1 to 240c505 Compare November 13, 2023 08:29
@Xiaohanjlll
Copy link
Contributor Author

please show the test result.

image

jyao1
jyao1 reviewed Nov 13, 2023
View reviewed changes
library/spdm_responder_conformance_test_lib/spdm_responder_test_7_measurements.c Outdated
{SPDM_RESPONDER_TEST_CASE_MEASUREMENTS_SPDM_MEASUREMENT_BLOCK,
"spdm_test_case_measurements_success_measurements_block",
spdm_test_case_measurements_success_measurement_block,
spdm_test_case_measurements_setup_measurement_block,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use spdm_test_case_measurements_setup_version_any?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I modified these questions

@jyao1 jyao1 merged commit 1d2c4a0 into DMTF:main Nov 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyao1 jyao1 jyao1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Xiaohanjlll @jyao1