Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parameter for UnsupportedRequest #2619

Closed
steven-bellock opened this issue Mar 12, 2024 · 1 comment · Fixed by #2630
Closed

Incorrect parameter for UnsupportedRequest #2619

steven-bellock opened this issue Mar 12, 2024 · 1 comment · Fixed by #2630
Assignees
Labels
bug Something isn't working

Comments

@steven-bellock
Copy link
Contributor

There are many instances of

if (libspdm_get_connection_version(spdm_context) < SPDM_MESSAGE_VERSION_11) {
return libspdm_generate_error_response(spdm_context,
SPDM_ERROR_CODE_UNSUPPORTED_REQUEST, 0,
response_size, response);
}
where a value of 0 is given for the error data, rather than the RequestResponseCode in the request message.

@steven-bellock steven-bellock added the bug Something isn't working label Mar 12, 2024
@jyao1 jyao1 self-assigned this Mar 18, 2024
@jyao1
Copy link
Member

jyao1 commented Mar 18, 2024

Please search and fix all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants