Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error code for unsupported_req error. #2630

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

jyao1
Copy link
Member

@jyao1 jyao1 commented Mar 22, 2024

Fix #2619

Copy link
Contributor

@steven-bellock steven-bellock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (libspdm_get_connection_version(context) < SPDM_MESSAGE_VERSION_11) {
return libspdm_generate_encap_error_response(
context, SPDM_ERROR_CODE_UNSUPPORTED_REQUEST,
0, response_size, response);
}
code like this shouldn't even exist. Ie, if the negotiated version is 1.0 then libspdm_get_encap_response_certificate should never be called. I can file a separate issue for that.

@steven-bellock steven-bellock added the bug Something isn't working label Mar 24, 2024
@jyao1 jyao1 merged commit d6a8003 into DMTF:main Mar 25, 2024
97 checks passed
@jyao1 jyao1 deleted the unsupported branch March 25, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect parameter for UnsupportedRequest
2 participants