Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request_response_code checking for GET_SUPPORTED_EVENT_TYPES request message is wrong. #2643

Closed
Zhiqiang520 opened this issue Mar 29, 2024 · 0 comments · Fixed by #2648
Closed

request_response_code checking for GET_SUPPORTED_EVENT_TYPES request message is wrong. #2643

Zhiqiang520 opened this issue Mar 29, 2024 · 0 comments · Fixed by #2648
Assignees
@steven-bellock
Labels
bug Something isn't working

Comments

@Zhiqiang520
Copy link
Contributor

request_response_code checking for GET_SUPPORTED_EVENT_TYPES request message is wrong.

I think SPDM_SUPPORTED_EVENT_TYPES at line 30 should be changed to SPDM_GET_SUPPORTED_EVENT_TYPES.

libspdm/library/spdm_responder_lib/libspdm_rsp_supported_event_types.c

Lines 29 to 30 in d6a8003

/* -=[Check Parameters Phase]=- */
LIBSPDM_ASSERT(spdm_request->header.request_response_code == SPDM_SUPPORTED_EVENT_TYPES);

@jyao1 jyao1 added the bug Something isn't working label Mar 29, 2024
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Mar 29, 2024
@steven-bellock
Fix EVENT_TYPES issues
dcb0a93 
Fix DMTF#2641.
Fix DMTF#2642.
Fix DMTF#2643.

Signed-off-by: Steven Bellock <[email protected]>
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Apr 1, 2024
@steven-bellock
Fix EVENT_TYPES issues
2c2b3d6 
Fix DMTF#2641.
Fix DMTF#2642.
Fix DMTF#2643.

Signed-off-by: Steven Bellock <[email protected]>
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Apr 1, 2024
@steven-bellock
Fix EVENT_TYPES issues
642e660 
Fix DMTF#2641.
Fix DMTF#2642.
Fix DMTF#2643.

These fixes include a workaround for DMTF#2645 in https://github.com/DMTF/libspdm/blob/main/unit_test/test_spdm_requester/get_event_types.c. When that issue is fixed the workaround should be reverted.

Signed-off-by: Steven Bellock <[email protected]>
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Apr 1, 2024
@steven-bellock
Fix EVENT_TYPES issues
84011c9 
Fix DMTF#2641.
Fix DMTF#2642.
Fix DMTF#2643.

These fixes include a workaround for DMTF#2645 in https://github.com/DMTF/libspdm/blob/main/unit_test/test_spdm_requester/get_event_types.c. When that issue is fixed the workaround should be reverted.

Signed-off-by: Steven Bellock <[email protected]>
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Apr 1, 2024
@steven-bellock
Fix EVENT_TYPES issues
a8e8191 
Fix DMTF#2641.
Fix DMTF#2642.
Fix DMTF#2643.

These fixes include a workaround for DMTF#2645 in https://github.com/DMTF/libspdm/blob/main/unit_test/test_spdm_requester/get_event_types.c. When that issue is fixed the workaround should be reverted.

Signed-off-by: Steven Bellock <[email protected]>
@steven-bellock steven-bellock mentioned this issue Apr 1, 2024
Merged
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Apr 2, 2024
@steven-bellock
Fix EVENT_TYPES issues
8d9e4a2 
Fix DMTF#2641.
Fix DMTF#2642.
Fix DMTF#2643.

These fixes include a workaround for DMTF#2645 in https://github.com/DMTF/libspdm/blob/main/unit_test/test_spdm_requester/get_event_types.c. When that issue is fixed the workaround should be reverted.

Signed-off-by: Steven Bellock <[email protected]>
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Apr 2, 2024
@steven-bellock
Fix EVENT_TYPES issues
0bf3da0 
Fix DMTF#2641.
Fix DMTF#2642.
Fix DMTF#2643.

These fixes include a workaround for DMTF#2645 in https://github.com/DMTF/libspdm/blob/main/unit_test/test_spdm_requester/get_event_types.c. When that issue is fixed the workaround should be reverted.

Signed-off-by: Steven Bellock <[email protected]>
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Apr 2, 2024
@steven-bellock
Fix EVENT_TYPES issues
d089009 
Fix DMTF#2641.
Fix DMTF#2642.
Fix DMTF#2643.

These fixes include a workaround for DMTF#2645 in https://github.com/DMTF/libspdm/blob/main/unit_test/test_spdm_requester/get_event_types.c. When that issue is fixed the workaround should be reverted.

Signed-off-by: Steven Bellock <[email protected]>
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Apr 3, 2024
@steven-bellock
Fix EVENT_TYPES issues
18b943b 
Fix DMTF#2641.
Fix DMTF#2642.
Fix DMTF#2643.

These fixes include a workaround for DMTF#2645 in https://github.com/DMTF/libspdm/blob/main/unit_test/test_spdm_requester/get_event_types.c. When that issue is fixed the workaround should be reverted.

Signed-off-by: Steven Bellock <[email protected]>
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Apr 3, 2024
@steven-bellock
Fix EVENT_TYPES issues
e62ed10 
Fix DMTF#2641.
Fix DMTF#2642.
Fix DMTF#2643.

These fixes include a workaround for DMTF#2645 in https://github.com/DMTF/libspdm/blob/main/unit_test/test_spdm_requester/get_event_types.c. When that issue is fixed the workaround should be reverted.

Signed-off-by: Steven Bellock <[email protected]>
@jyao1 jyao1 closed this as completed in a284716 Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steven-bellock steven-bellock

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix EVENT_TYPES issues steven-bellock/libspdm
3 participants
@steven-bellock @jyao1 @Zhiqiang520