SET_CERTIFICATE.Param1 case is not handled

[steven-bellock]

Param1 is set in

libspdm/library/spdm_requester_lib/libspdm_req_set_certificate.c

Lines 118 to 139 in 883c31e

	spdm_request->header.param1 = slot_id & SPDM_SET_CERTIFICATE_REQUEST_SLOT_ID_MASK;
	spdm_request->header.param2 = 0;
	if (spdm_request->header.spdm_version >= SPDM_MESSAGE_VERSION_13) {
	/*And the bit[0~3] of request_attribute must be 0.*/
	if ((request_attribute & SPDM_SET_CERTIFICATE_REQUEST_SLOT_ID_MASK) != 0) {
	return LIBSPDM_STATUS_INVALID_PARAMETER;
	}
	if ((request_attribute & SPDM_SET_CERTIFICATE_REQUEST_ATTRIBUTES_ERASE) != 0) {
	/*the CertChain field shall be absent*/
	cert_chain_size = 0;
	/*the value of SetCertModel shall be zero*/
	spdm_request->header.param1 &= ~SPDM_SET_CERTIFICATE_REQUEST_ATTRIBUTES_CERT_MODEL_MASK;
	/*set Erase bit */
	spdm_request->header.param1 |= SPDM_SET_CERTIFICATE_REQUEST_ATTRIBUTES_ERASE;
	}
	if (spdm_context->connection_info.multi_key_conn_rsp) {
	spdm_request->header.param2 = key_pair_id;
	}
	}

It does not handle the case when Erase is not set. In such a case Param1 is just the slot ID, which ignores the certificate model field.

[steven-bellock]

In addition

 if (spdm_request->header.spdm_version >= SPDM_MESSAGE_VERSION_13) { 
     /*And the bit[0~3] of request_attribute must be 0.*/ 
     if ((request_attribute & SPDM_SET_CERTIFICATE_REQUEST_SLOT_ID_MASK) != 0) { 
         return LIBSPDM_STATUS_INVALID_PARAMETER; 
     } 

is incorrect as the send buffer has already been acquired. This check needs to be before the send buffer has been acquired.