the vendor_cmds requester unit_test has some error

[Wenxing-hou]

When any requester unit_test is called after the vendor_cmds requester unit_test, the GCC release build failed.

There is a example PR:
Wenxing-hou#17

[steven-bellock]

Removing -flto from compilation will let this pass. Seems to be a compiler bug. Tested on

gcc (Ubuntu 13.2.0-23ubuntu4) 13.2.0

[steven-bellock]

Also reproduces in

gcc-14 (Ubuntu 14-20240412-0ubuntu1) 14.0.1 20240412 (experimental) [master r14-9935-g67e1433a94f]

[steven-bellock]

This is "fixed" by moving

libspdm/unit_test/test_spdm_requester/vendor_request.c

Lines 222 to 227 in a3e5b99

	libspdm_test_context_t m_libspdm_requester_vendor_cmds_test_context = {
	LIBSPDM_TEST_CONTEXT_VERSION,
	true,
	libspdm_requester_vendor_cmds_test_send_message,
	libspdm_requester_vendor_cmds_test_receive_message,
	};

and

libspdm/unit_test/test_spdm_requester/error_test/vendor_request_err.c

Lines 219 to 224 in a3e5b99

	libspdm_test_context_t m_libspdm_requester_vendor_cmds_err_test_context = {
	LIBSPDM_TEST_CONTEXT_VERSION,
	true,
	libspdm_requester_vendor_cmds_err_test_send_message,
	libspdm_requester_vendor_cmds_err_test_receive_message,
	};

inside their respective _main functions. This should be done anyways since those values are not needed at file scope and definitely do not need external linkage.

[steven-bellock]

libspdm/unit_test/test_spdm_requester/vendor_request.c

Lines 130 to 131 in 704d565

	status = libspdm_transport_test_decode_message(
	spdm_test_context, &session_id, &is_app_message, true,

libspdm/unit_test/test_spdm_requester/error_test/vendor_request_err.c

Lines 118 to 119 in 704d565

	status = libspdm_transport_test_decode_message(
	spdm_test_context, &session_id, &is_app_message, true,

Also use of spdm_test_context is incorrect. It should be spdm_context. I'm surprised the call to the function is successful, but that's C for you. This issue was found by Rani at NVIDIA using his formal verification tool.