Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fuzzy test case libspdm_test_responder_chunk_send_ack_case1 #2622

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

Xiaohanjlll
Copy link
Contributor

@Xiaohanjlll Xiaohanjlll commented Mar 15, 2024

Fix: #2624

@jyao1 jyao1 added the test For tests and testing infrastructure label Mar 15, 2024
@jyao1
Copy link
Member

jyao1 commented Mar 15, 2024

what issue this patch is trying to fix?

@Xiaohanjlll Xiaohanjlll marked this pull request as draft March 18, 2024 01:24
@Xiaohanjlll Xiaohanjlll force-pushed the fuzz_chunk_test branch 2 times, most recently from 40c4317 to bb2abc2 Compare March 18, 2024 08:09
@Xiaohanjlll Xiaohanjlll marked this pull request as ready for review March 18, 2024 08:44
@Xiaohanjlll Xiaohanjlll marked this pull request as draft March 20, 2024 06:06
spdm_context->local_context.capability.data_transfer_size =
chunk_send_request->chunk_size + sizeof(spdm_chunk_send_request_t);

if (bytes_total - bytes_sent == chunk_send_request->chunk_size) {
chunk_send_request->header.param1 = SPDM_CHUNK_SEND_REQUEST_ATTRIBUTE_LAST_CHUNK;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I have made the modifications. I will commit this modification with a new PR.

@Xiaohanjlll Xiaohanjlll marked this pull request as ready for review March 21, 2024 05:15
@jyao1 jyao1 merged commit c2d0045 into DMTF:main Mar 21, 2024
97 checks passed
@Xiaohanjlll Xiaohanjlll deleted the fuzz_chunk_test branch July 15, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test For tests and testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_spdm_responder_chunk_send_ack libFuzzer fuzzing test Heap-buffer-overflow
2 participants