Fix vendor defined request size

[m-milinkovic]

The pointer of Vendor Defined Request is moved, then the request size should be adjusted accordingly.

[steven-bellock]

@m-milinkovic you'll need to replace the whole copyright header with

/**
 *  Copyright Notice:
 *  Copyright 2023-2024 DMTF. All rights reserved.
 *  License: BSD 3-Clause License. For full text see link: https://github.com/DMTF/libspdm/blob/main/LICENSE.md
 **/

For some reason this file doesn't have the Copyright Notice: line.

[jyao1]

@uvinrg, could you please take a look?

[jyao1]

@m-milinkovic, I think below calculation is risky, since it includes the transport padding.

    req_size = (uint16_t)request_size -
               sizeof(spdm_vendor_defined_request_msg_t) -
               ((const spdm_vendor_defined_request_msg_t*)request)->len -
               sizeof(uint16_t);

The req_size should be got from 2 bytes field ReqLength in spdm_request, which is precise size. See below:

    req_vendor_id = ((const uint8_t *)request) +
                    sizeof(spdm_vendor_defined_request_msg_t);
    req_size = *(const uint16_t *)(req_vendor_id + spdm_request->len);

[m-milinkovic]

@m-milinkovic, I think below calculation is risky, since it includes the transport padding.

    req_size = (uint16_t)request_size -
               sizeof(spdm_vendor_defined_request_msg_t) -
               ((const spdm_vendor_defined_request_msg_t*)request)->len -
               sizeof(uint16_t);

The req_size should be got from 2 bytes field ReqLength in spdm_request, which is precise size. See below:

    req_vendor_id = ((const uint8_t *)request) +
                    sizeof(spdm_vendor_defined_request_msg_t);
    req_size = *(const uint16_t *)(req_vendor_id + spdm_request->len);

Done.
Thank you for the review!

Please note that req_data could be obtained in a similar manner (via req_vendor_id), but I already made this commit a bit dirty by renaming spdm_vendor_defined_response_msg_t to spdm_vendor_defined_request_msg_t. I prefer not to go beyond that trivial change.

[m-milinkovic]

Also, please note that, if you decide to merge this commit, I'll check other affected repos (e.g., SPDM-Responder-Validator) and propose a solution as well.

[uvinrg]

Hi guys, sorry for the late response. Thank you for the fix, looks good.